[
https://issues.apache.org/jira/browse/AMQ-8463?focusedWorklogId=953006&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-953006
]
ASF GitHub Bot logged work on AMQ-8463:
---------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/25 19:37
Start Date: 17/Jan/25 19:37
Worklog Time Spent: 10m
Work Description: mattrpav commented on code in PR #1329:
URL: https://github.com/apache/activemq/pull/1329#discussion_r1920661468
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -1971,10 +1978,17 @@ private final boolean tryCursorAdd(final Message msg)
throws Exception {
final void messageSent(final ConnectionContext context, final Message msg)
throws Exception {
pendingSends.decrementAndGet();
+
destinationStatistics.getEnqueues().increment();
destinationStatistics.getMessages().increment();
destinationStatistics.getMessageSize().addSize(msg.getSize());
+ MessageFlowStats tmpMessageFlowStats =
destinationStatistics.getMessageFlowStats();
+
+ if(isAdvancedMessageStatisticsEnabled() && tmpMessageFlowStats !=
null) {
Review Comment:
Resolved w/ cshannon's commit
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/DestinationStatistics.java:
##########
@@ -186,6 +177,11 @@ public void reset() {
maxUncommittedExceededCount.reset();
networkEnqueues.reset();
networkDequeues.reset();
+
+ MessageFlowStatsImpl tmpMessageFlowStats = messageFlowStats;
Review Comment:
Resolved w/ cshannon's commit
Issue Time Tracking
-------------------
Worklog Id: (was: 953006)
Time Spent: 4h 50m (was: 4h 40m)
> Add advancedMessageStatistics to destinations
> ---------------------------------------------
>
> Key: AMQ-8463
> URL: https://issues.apache.org/jira/browse/AMQ-8463
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Components: Broker
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 6.2.0
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Observability and tracking metrics on the destination can provide current
> message age and indication of message flow activity.
> // Most recent enqueued message info
> enqueuedMessageID
> enqueuedMessageTimestamp
> enqueuedMessageBrokerInTime
> // Most recent dequeued message info
> dequeuedMessageID
> dequeuedMessageTimestamp
> dequeuedMessageBrokerInTime
> // First enqueue since boot
> firstEnqueuedMessageID
> firstEnqueuedMessageTimestamp
> firstEnqueuedMessageBrokerInTime
> // First dequeue since boot
> firstDequeuedMessageID
> firstDequeuedMessageTimestamp
> firstDequeuedMessageBrokerInTime
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
