[
https://issues.apache.org/jira/browse/AMQ-8463?focusedWorklogId=953476&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-953476
]
ASF GitHub Bot logged work on AMQ-8463:
---------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/25 23:56
Start Date: 21/Jan/25 23:56
Worklog Time Spent: 10m
Work Description: mattrpav commented on code in PR #1329:
URL: https://github.com/apache/activemq/pull/1329#discussion_r1924507072
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/DestinationStatistics.java:
##########
@@ -252,7 +242,29 @@ public void setParent(DestinationStatistics parent) {
maxUncommittedExceededCount.setParent(null);
networkEnqueues.setParent(null);
networkDequeues.setParent(null);
+ // [AMQ-9437] Advanced Message Statistics do not parent.
}
}
+ // This is the only method that can mutate the messageFlowStats state
+ // so we only need to synchronize this method to make sure we don't have 2
threads
+ // trying to set at the same time.
+ public synchronized void setAdvancedMessageStatisticsEnabled(boolean
enabled) {
+ // we can just use the get() here on the reference as no other spot can
Review Comment:
Comment removed via commit c079d1bd03df5a2faf35f2ec9625e7e51b2a4973
Issue Time Tracking
-------------------
Worklog Id: (was: 953476)
Time Spent: 6h (was: 5h 50m)
> Add advancedMessageStatistics to destinations
> ---------------------------------------------
>
> Key: AMQ-8463
> URL: https://issues.apache.org/jira/browse/AMQ-8463
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Components: Broker
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 6.2.0, 5.18.7
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Observability and tracking metrics on the destination can provide current
> message age and indication of message flow activity.
> // Most recent enqueued message info
> enqueuedMessageID
> enqueuedMessageTimestamp
> enqueuedMessageBrokerInTime
> // Most recent dequeued message info
> dequeuedMessageID
> dequeuedMessageTimestamp
> dequeuedMessageBrokerInTime
> // First enqueue since boot
> firstEnqueuedMessageID
> firstEnqueuedMessageTimestamp
> firstEnqueuedMessageBrokerInTime
> // First dequeue since boot
> firstDequeuedMessageID
> firstDequeuedMessageTimestamp
> firstDequeuedMessageBrokerInTime
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
