[
https://issues.apache.org/jira/browse/ARTEMIS-5107?focusedWorklogId=953432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-953432
]
ASF GitHub Bot logged work on ARTEMIS-5107:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/25 20:08
Start Date: 21/Jan/25 20:08
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5451:
URL: https://github.com/apache/activemq-artemis/pull/5451#discussion_r1924303411
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java:
##########
@@ -76,7 +76,7 @@ public static SyncDataType getDataType(byte code) {
public ReplicationStartSyncMessage(boolean beforeTwoEighteen) {
super(REPLICATION_START_FINISH_SYNC);
- this.beforeTwoEighteen = synchronizationIsFinished;
+ this.beforeTwoEighteen = beforeTwoEighteen;
Review Comment:
The main fix for the original issue (i.e. ARTEMIS-3767) was in
`ReplicationAddMessage` and `ReplicationAddTXMessage`. The only important part
of the fix in `ReplicationStartSyncMessage` is in `decodeRest` where versions
before 2.18.0 will send less data than newer versions. The `beforeTwoEighteen`
variable is not actually needed because sending _more_ data to an older version
is not a problem. The older version will simply ignore it. I'm updating the fix
to take this into account.
Issue Time Tracking
-------------------
Worklog Id: (was: 953432)
Time Spent: 0.5h (was: 20m)
> Using uninitialized value in ReplicationStartSyncMessage
> --------------------------------------------------------
>
> Key: ARTEMIS-5107
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5107
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Pavel Nekrasov
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In lines
> [77-80|https://github.com/apache/activemq-artemis/blob/8e4bc33dc4d7b4d2031c1bda996c7ce002a3d0e8/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java#L77-L80],
> an uninitialized value {{synchronizationIsFinished}} is assigned, while the
> {{beforeTwoEighteen}} parameter passed to the constructor is not used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
