[
https://issues.apache.org/jira/browse/ARTEMIS-5107?focusedWorklogId=953700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-953700
]
ASF GitHub Bot logged work on ARTEMIS-5107:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/25 17:24
Start Date: 22/Jan/25 17:24
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5451:
URL: https://github.com/apache/activemq-artemis/pull/5451#discussion_r1925700321
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java:
##########
@@ -76,7 +76,7 @@ public static SyncDataType getDataType(byte code) {
public ReplicationStartSyncMessage(boolean beforeTwoEighteen) {
super(REPLICATION_START_FINISH_SYNC);
- this.beforeTwoEighteen = synchronizationIsFinished;
+ this.beforeTwoEighteen = beforeTwoEighteen;
Review Comment:
The original original PR and email discussion had suggested there was an
issue with the newer servers sending the additional data to the old broker, but
it would certainly seem like thats what it has always continued doing even
after the subsequent PR was applied, suggesting that isnt the case (or that in
the end noone hit it again).
In general I do think it makes more sense to prevent sending such new data
to old brokers when making such changes, but it would appear that has always
been the case here, so if it hasnt caused issue then at this stage years later
perhaps just removing the gating check is the way to go at this point.
Issue Time Tracking
-------------------
Worklog Id: (was: 953700)
Time Spent: 40m (was: 0.5h)
> Using uninitialized value in ReplicationStartSyncMessage
> --------------------------------------------------------
>
> Key: ARTEMIS-5107
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5107
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Pavel Nekrasov
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In lines
> [77-80|https://github.com/apache/activemq-artemis/blob/8e4bc33dc4d7b4d2031c1bda996c7ce002a3d0e8/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java#L77-L80],
> an uninitialized value {{synchronizationIsFinished}} is assigned, while the
> {{beforeTwoEighteen}} parameter passed to the constructor is not used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
