[ 
https://issues.apache.org/jira/browse/ARTEMIS-5333?focusedWorklogId=959522&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-959522
 ]

ASF GitHub Bot logged work on ARTEMIS-5333:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Feb/25 21:30
            Start Date: 28/Feb/25 21:30
    Worklog Time Spent: 10m 
      Work Description: gtully commented on code in PR #5537:
URL: https://github.com/apache/activemq-artemis/pull/5537#discussion_r1976029496


##########
docs/user-manual/paging.adoc:
##########
@@ -158,7 +158,7 @@ You can also specify `global-max-messages` on the main 
configuration, specifying
 
 When you have more messages than what is configured `global-max-size` any new 
produced message will make that destination to go through its paging policy.
 
-`global-max-size` is calculated as half of the max memory available to the 
Java Virtual Machine, unless specified on the `broker.xml` configuration.
+`global-max-size` is calculated as `global-max-size-percent-of-jvm-max-memory` 
of the max memory available to the Java Virtual Machine, unless specified on 
the `broker.xml` configuration. The default value of 
`global-max-size-percent-of-jvm-max-memory` is 50% or half.

Review Comment:
   thanks, yes, that is indeed better. 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 959522)
    Time Spent: 0.5h  (was: 20m)

> add support for setting global max size percent of jvm max memory
> -----------------------------------------------------------------
>
>                 Key: ARTEMIS-5333
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5333
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 2.39.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> global-max-size can be set to a value or you get the default which is half 
> the jvm max memory.
> it would be nice to be able to configure the half, so that a user could 
> configure the percent of max memory to something other than 50%
> depending on work load, and in particular when in containers where the jvm 
> can be container aware, it is tricky to align a particular global-max-size 
> value,  working with percentages makes this configuration simpler.
> global-max-size-percent-of-jvm-max-memory would do it, and be used when 
> calculating the default in place of the current 50%, it can default to 50%



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to