[
https://issues.apache.org/jira/browse/ARTEMIS-5333?focusedWorklogId=960002&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-960002
]
ASF GitHub Bot logged work on ARTEMIS-5333:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/25 15:21
Start Date: 04/Mar/25 15:21
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5537:
URL: https://github.com/apache/activemq-artemis/pull/5537#discussion_r1979675865
##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationParserTest.java:
##########
@@ -775,6 +776,7 @@ public void testMaxSize() throws Exception {
assertEquals(10 * 1024 * 1024, configuration.getGlobalMaxSize());
assertEquals(1000, configuration.getGlobalMaxMessages());
+ assertEquals(30, configuration.getGlobalMaxSizePercentOfJvmMaxMemory());
Review Comment:
I would use a different number from the one you used on the XML.. in case
the XML gets parsed by accident.
Issue Time Tracking
-------------------
Worklog Id: (was: 960002)
Time Spent: 40m (was: 0.5h)
> add support for setting global max size percent of jvm max memory
> -----------------------------------------------------------------
>
> Key: ARTEMIS-5333
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5333
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.39.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> global-max-size can be set to a value or you get the default which is half
> the jvm max memory.
> it would be nice to be able to configure the half, so that a user could
> configure the percent of max memory to something other than 50%
> depending on work load, and in particular when in containers where the jvm
> can be container aware, it is tricky to align a particular global-max-size
> value, working with percentages makes this configuration simpler.
> global-max-size-percent-of-jvm-max-memory would do it, and be used when
> calculating the default in place of the current 50%, it can default to 50%
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
