[
https://issues.apache.org/jira/browse/ARTEMIS-5434?focusedWorklogId=966517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-966517
]
ASF GitHub Bot logged work on ARTEMIS-5434:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/25 07:18
Start Date: 17/Apr/25 07:18
Worklog Time Spent: 10m
Work Description: ViliusS commented on PR #5639:
URL:
https://github.com/apache/activemq-artemis/pull/5639#issuecomment-2812021316
Some context [how Google Error Reporting
works](https://cloud.google.com/error-reporting/docs/grouping-errors#how_errors_are_grouped).
It analyzes all log messages and tries to find exceptions in them. If
exception is found monitoring agent is notified about new problem within an
environment. If the same exception is found it is grouped and produces
histogram, so monitoring agent can clearly see when the problem started to
appear. See the following screenshot as an example:
If the error is marked as resolved and later reoccurs, monitoring agent is
again notified, that the same error resurfaced.
All of this is great except the part how Google Error Reporting
differentiates between what is the same error and what is not. I'm not sure if
it takes into account what is written after exception name (in Artemis case the
part between []), but it definitely looks into full package name in the first
line of the exception. If
`org.apache.activemq.artemis.api.core.ActiveMQIllegalStateException` and
`com.third.party.package.ActiveMQIllegalStateException` are found but exception
structure just returns `ActiveMQIllegalStateException` in the first line it is
treated as the same error case, which is not.
This PR also would make exception format more inline with what how
exceptions are returned from standard Java libraries. `java.lang` example:
Issue Time Tracking
-------------------
Worklog Id: (was: 966517)
Time Spent: 0.5h (was: 20m)
> Use full exception name in exceptions
> -------------------------------------
>
> Key: ARTEMIS-5434
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5434
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Vilius Šumskas
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> It would be great to have full package name in the exception header.
> Currently Artemis exceptions only include the short name of the exception. On
> logging systems where exceptions are caught and tracked if they are repeating
> errors (like for example Google Error Reporting), this groups different
> Artemis exceptions into single error group.
> See
> [https://github.com/apache/logging-log4j2/pull/3586#discussion_r2044006120]
> for more information and screenshots.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
