[
https://issues.apache.org/jira/browse/ARTEMIS-5434?focusedWorklogId=966609&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-966609
]
ASF GitHub Bot logged work on ARTEMIS-5434:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/25 15:04
Start Date: 17/Apr/25 15:04
Worklog Time Spent: 10m
Work Description: ppkarwasz commented on code in PR #5639:
URL: https://github.com/apache/activemq-artemis/pull/5639#discussion_r2049100971
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQException.java:
##########
@@ -75,6 +75,6 @@ public ActiveMQExceptionType getType() {
@Override
public String toString() {
- return this.getClass().getSimpleName() + "[errorType=" + type + "
message=" + getMessage() + "]";
+ return this.getClass().getName() + "[errorType=" + type + " message=" +
getMessage() + "]";
Review Comment:
```suggestion
return this.getClass().getName() + ": [errorType=" + type + "
message=" + getMessage() + "]";
```
It is probably better to keep the format `<fully_qualified_class_name>:
<custom_message>`.
Issue Time Tracking
-------------------
Worklog Id: (was: 966609)
Time Spent: 40m (was: 0.5h)
> Use full exception name in exceptions
> -------------------------------------
>
> Key: ARTEMIS-5434
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5434
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Vilius Šumskas
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It would be great to have full package name in the exception header.
> Currently Artemis exceptions only include the short name of the exception. On
> logging systems where exceptions are caught and tracked if they are repeating
> errors (like for example Google Error Reporting), this groups different
> Artemis exceptions into single error group.
> See
> [https://github.com/apache/logging-log4j2/pull/3586#discussion_r2044006120]
> for more information and screenshots.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
