[
https://issues.apache.org/jira/browse/ARTEMIS-5441?focusedWorklogId=967153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-967153
]
ASF GitHub Bot logged work on ARTEMIS-5441:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/25 22:01
Start Date: 22/Apr/25 22:01
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #5646:
URL: https://github.com/apache/activemq-artemis/pull/5646#discussion_r2054950611
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTimedWriter.java:
##########
@@ -118,15 +120,15 @@ public void incrementTask() {
pendingTasksUpdater.incrementAndGet(this);
}
- public void addTask(OperationContext context,
+ public int addTask(OperationContext context,
PagedMessage message,
Transaction tx,
- RouteContextList listCtx) {
+ RouteContextList listCtx, boolean
useFlowControl) {
logger.trace("Adding paged message {} to paged writer", message);
int credits = Math.min(message.getEncodeSize() +
PageReadWriter.SIZE_RECORD, maxCredits);
- writeCredits.acquireUninterruptibly(credits);
+ //writeCredits.acquireUninterruptibly(credits);
Review Comment:
Commented out code is usually confusing for future maintenance, recommend
removing this line
Issue Time Tracking
-------------------
Worklog Id: (was: 967153)
Time Spent: 20m (was: 10m)
> Replication start will deadlock / starve if PageTimedWriter is flow controlled
> ------------------------------------------------------------------------------
>
> Key: ARTEMIS-5441
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5441
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.40.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.41.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
