[
https://issues.apache.org/jira/browse/ARTEMIS-5441?focusedWorklogId=967231&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-967231
]
ASF GitHub Bot logged work on ARTEMIS-5441:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/25 12:37
Start Date: 23/Apr/25 12:37
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5646:
URL: https://github.com/apache/activemq-artemis/pull/5646#discussion_r2055954835
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTimedWriter.java:
##########
@@ -118,15 +120,18 @@ public void incrementTask() {
pendingTasksUpdater.incrementAndGet(this);
}
- public void addTask(OperationContext context,
+ public int addTask(OperationContext context,
PagedMessage message,
Transaction tx,
- RouteContextList listCtx) {
+ RouteContextList listCtx, boolean
useFlowControl) {
logger.trace("Adding paged message {} to paged writer", message);
+ // the module using the page operation should later call flowControl
from this class.
+ // the only exception to this would be from tests where we don't really
care about flow control on the TimedExecutor
+ // also: the credits is based on the page size, and we use the
encodeSize to flow it.
int credits = Math.min(message.getEncodeSize() +
PageReadWriter.SIZE_RECORD, maxCredits);
- writeCredits.acquireUninterruptibly(credits);
+
Review Comment:
Oh yeah.. good point!
thanks a lot
Issue Time Tracking
-------------------
Worklog Id: (was: 967231)
Time Spent: 1h (was: 50m)
> Replication start will deadlock / starve if PageTimedWriter is flow controlled
> ------------------------------------------------------------------------------
>
> Key: ARTEMIS-5441
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5441
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.40.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.41.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
