[
https://issues.apache.org/jira/browse/ARTEMIS-5717?focusedWorklogId=989121&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-989121
]
ASF GitHub Bot logged work on ARTEMIS-5717:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Oct/25 20:14
Start Date: 27/Oct/25 20:14
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6009:
URL: https://github.com/apache/activemq-artemis/pull/6009#discussion_r2466957363
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java:
##########
@@ -2396,10 +2408,20 @@ public synchronized RoutingStatus doSend(final
Transaction tx,
final String senderName,
final boolean noAutoCreateQueue,
final RoutingContext
routingContext) throws Exception {
+ return doSend(tx, msg.getRoutingType(), msg, originalAddress, direct,
senderName, noAutoCreateQueue, routingContext);
+ }
- RoutingStatus result = RoutingStatus.OK;
+ @Override
+ public synchronized RoutingStatus doSend(final Transaction tx,
+ final RoutingType routingType,
+ final Message message,
+ final SimpleString originalAddress,
+ final boolean direct,
+ final String senderName,
+ final boolean noAutoCreateQueue,
+ final RoutingContext
routingContext) throws Exception {
- RoutingType routingType = msg.getRoutingType();
+ RoutingStatus result = RoutingStatus.OK;
/* TODO-now: How to address here with AMQP?
Review Comment:
Everything looks good.
my only comment on the PR is that I think this comment here should be
removed now.
you are already dealing with the routingType... so this can be removed IMO.
Issue Time Tracking
-------------------
Worklog Id: (was: 989121)
Time Spent: 1h 50m (was: 1h 40m)
> BrokerConnection Receiver would lose messages on routing type mismatch
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-5717
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5717
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Timothy A. Bish
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.44.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
