[
https://issues.apache.org/jira/browse/ARTEMIS-5738?focusedWorklogId=990413&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-990413
]
ASF GitHub Bot logged work on ARTEMIS-5738:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/25 12:30
Start Date: 05/Nov/25 12:30
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #6024:
URL: https://github.com/apache/activemq-artemis/pull/6024#discussion_r2494268576
##########
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/LDAPLoginModule.java:
##########
@@ -71,6 +71,20 @@ public class LDAPLoginModule implements AuditLoginModule {
private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ private static final ThreadLocal<Map<String, String>>
environmentThreadLocal = new ThreadLocal<>();
Review Comment:
I wonder if there is some way to use the login context initialise and shared
state map to pass the ssl env down to the socket factory. It may be worth a
look.
Recently I added a singleton to the kube login module, thinking that the
need for multiple instances that need to talk to different servers does not
exist. I guess with ldap (being a single centralised source of truth) the need
for multiple instances won't exist either. Currently, for ssl with ldap, the
jvm gets configured, so the tls config is currently always shared. Maybe a
singleton is sufficient.
see:
https://github.com/apache/activemq-artemis/pull/5963/files#diff-bedf8cbd7661c15968c3c7318999c811d7fd89720f71012b8e9b3af9240e856eR61
Issue Time Tracking
-------------------
Worklog Id: (was: 990413)
Time Spent: 20m (was: 10m)
> Improve LDAPLoginModule ssl support
> -----------------------------------
>
> Key: ARTEMIS-5738
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5738
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Align the SSL Support of LDAPLoginModule with the other connection resources,
> such as the connectors.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
