[
https://issues.apache.org/jira/browse/ARTEMIS-5738?focusedWorklogId=990499&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-990499
]
ASF GitHub Bot logged work on ARTEMIS-5738:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/25 07:48
Start Date: 06/Nov/25 07:48
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #6024:
URL: https://github.com/apache/activemq-artemis/pull/6024#discussion_r2497853476
##########
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/LDAPLoginModule.java:
##########
@@ -71,6 +71,20 @@ public class LDAPLoginModule implements AuditLoginModule {
private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ private static final ThreadLocal<Map<String, String>>
environmentThreadLocal = new ThreadLocal<>();
Review Comment:
The idea `to use the login context initialise and shared state map to pass
the ssl env down to the socket factory` is smart however LoginContext doesn't
expose any public method to access it from the socket factory.
I agree that multiple LDAPLoginModule instances shouldn't be necessary. I
could use system properties instead of environmentThreadLocal to pass the SSL
config to LDAPLoginSSLSocketFactory.
Issue Time Tracking
-------------------
Worklog Id: (was: 990499)
Time Spent: 50m (was: 40m)
> Improve LDAPLoginModule ssl support
> -----------------------------------
>
> Key: ARTEMIS-5738
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5738
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Align the SSL Support of LDAPLoginModule with the other connection resources,
> such as the connectors.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
