[ 
https://issues.apache.org/jira/browse/AMQNET-851?focusedWorklogId=991832&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-991832
 ]

ASF GitHub Bot logged work on AMQNET-851:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Nov/25 08:46
            Start Date: 15/Nov/25 08:46
    Worklog Time Spent: 10m 
      Work Description: davidvoit commented on code in PR #34:
URL: https://github.com/apache/activemq-nms-api/pull/34#discussion_r2529709762


##########
src/nms-api/NMSConnectionFactory.cs:
##########
@@ -75,6 +75,10 @@ static NMSConnectionFactory()
                 new ProviderFactoryInfo("Apache.NMS.ZMQ", 
"Apache.NMS.ZMQ.ConnectionFactory");
             schemaProviderFactoryMap["amqp"] =
                 new ProviderFactoryInfo("Apache.NMS.AMQP", 
"Apache.NMS.AMQP.ConnectionFactory");
+            schemaProviderFactoryMap["amqps"] =
+                new ProviderFactoryInfo("Apache.NMS.AMQP", 
"Apache.NMS.AMQP.ConnectionFactory");
+            schemaProviderFactoryMap["failover"] =

Review Comment:
   Wouldn't this be activemq:failover then? We could also implement a second 
level lookup if needed. look for tcp/ssl or amqp/amqps





Issue Time Tracking
-------------------

    Worklog Id:     (was: 991832)
    Time Spent: 0.5h  (was: 20m)

> Add support for AMQPS uri schema to activemq-nms-api
> ----------------------------------------------------
>
>                 Key: AMQNET-851
>                 URL: https://issues.apache.org/jira/browse/AMQNET-851
>             Project: ActiveMQ .Net
>          Issue Type: Improvement
>            Reporter: David Voit
>            Priority: Trivial
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The documentation would suggest 
> ([https://activemq.apache.org/components/nms/providers/amqp/uri-configuration)]
>  that you can just use amqps uris.
> But sadly the default NMSConnectionFactory doesn't handle amqps uris, and you 
> need to configure secure amqp support with a nmsprovider-amqps.config file.
> The github pull request also adds amqps:// support, just as amqp:// like the 
> documetation would suggest.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to