[
https://issues.apache.org/jira/browse/AMQNET-851?focusedWorklogId=992183&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-992183
]
ASF GitHub Bot logged work on AMQNET-851:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/25 08:46
Start Date: 18/Nov/25 08:46
Worklog Time Spent: 10m
Work Description: davidvoit commented on code in PR #34:
URL: https://github.com/apache/activemq-nms-api/pull/34#discussion_r2536899595
##########
src/nms-api/NMSConnectionFactory.cs:
##########
@@ -75,6 +75,10 @@ static NMSConnectionFactory()
new ProviderFactoryInfo("Apache.NMS.ZMQ",
"Apache.NMS.ZMQ.ConnectionFactory");
schemaProviderFactoryMap["amqp"] =
new ProviderFactoryInfo("Apache.NMS.AMQP",
"Apache.NMS.AMQP.ConnectionFactory");
+ schemaProviderFactoryMap["amqps"] =
+ new ProviderFactoryInfo("Apache.NMS.AMQP",
"Apache.NMS.AMQP.ConnectionFactory");
+ schemaProviderFactoryMap["failover"] =
Review Comment:
But failover: are currently so or so not working. I think it would be fine
to conenect it to amqp and go with activemq:failover for openwire as the new
default. What do you think, should we write some new uri parsind and decsision
logick or would this new default be fine?
Issue Time Tracking
-------------------
Worklog Id: (was: 992183)
Time Spent: 40m (was: 0.5h)
> Add support for AMQPS uri schema to activemq-nms-api
> ----------------------------------------------------
>
> Key: AMQNET-851
> URL: https://issues.apache.org/jira/browse/AMQNET-851
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Reporter: David Voit
> Priority: Trivial
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The documentation would suggest
> ([https://activemq.apache.org/components/nms/providers/amqp/uri-configuration)]
> that you can just use amqps uris.
> But sadly the default NMSConnectionFactory doesn't handle amqps uris, and you
> need to configure secure amqp support with a nmsprovider-amqps.config file.
> The github pull request also adds amqps:// support, just as amqp:// like the
> documetation would suggest.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
