[
https://issues.apache.org/jira/browse/AMQ-9692?focusedWorklogId=1001371&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1001371
]
ASF GitHub Bot logged work on AMQ-9692:
---------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/26 14:41
Start Date: 22/Jan/26 14:41
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #1484:
URL: https://github.com/apache/activemq/pull/1484#discussion_r2717190805
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/BaseDestination.java:
##########
@@ -311,12 +313,27 @@ public final MessageStore getMessageStore() {
@Override
public boolean isActive() {
- boolean isActive = destinationStatistics.getConsumers().getCount() > 0
||
- destinationStatistics.getProducers().getCount() > 0;
- if (isActive && isGcWithNetworkConsumers() &&
destinationStatistics.getConsumers().getCount() > 0) {
- isActive = hasRegularConsumers(getConsumers());
+ if (destinationStatistics.getProducers().getCount() > 0) {
+ return true;
}
- return isActive;
+
+ var destinationActive = true;
+ if (destinationStatistics.getConsumers().getCount() > 0) {
+ Predicate<Subscription> isActiveConsumer = subscription -> {
Review Comment:
That is a suggestion on how we could write it, I played around with the
logic a bit and i found it less confusing to write a predicate that checked if
the consumer could be GC'd vs is active . The predicate returns true if either
can gc network flag is true and it's a network consumer, or if the gc with only
wildcard flag is true and the subscription is a wildcard.
It also optimizes by doing an initial check to see if either flag is true
and if both are false we can skip iteration entirely. I used a for each loop vs
streams just for the slight performance boost as isActive() will probably be
called a lot on each destination (although streams would be a lot cleaner)
Issue Time Tracking
-------------------
Worklog Id: (was: 1001371)
Time Spent: 1h 40m (was: 1.5h)
> Support destination gc sweep of destinations with wild card consumers
> ---------------------------------------------------------------------
>
> Key: AMQ-9692
> URL: https://issues.apache.org/jira/browse/AMQ-9692
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Minor
> Fix For: 6.3.0, 5.19.2
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently, a wild-card consumer can hold up a destination from being
> automatically garbage collected. This change would add a policyEntry setting
> to allow garbage collection if the destination only has wild card consumers
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
