[
https://issues.apache.org/jira/browse/AMQ-9692?focusedWorklogId=1001387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1001387
]
ASF GitHub Bot logged work on AMQ-9692:
---------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/26 15:19
Start Date: 22/Jan/26 15:19
Worklog Time Spent: 10m
Work Description: cshannon commented on PR #1484:
URL: https://github.com/apache/activemq/pull/1484#issuecomment-3784972754
@mattrpav - The biggest thing now is I think the test coverage is lacking.
1. Some of the new methods could be unit tested . The new
hasActiveConsumers() and canGcConsumer predicate can probably be tested in
isolation as they are protected so maybe with mocks or something.
2. I think we need to double check there is sufficient test cover for the
different combinations of the gcWithOnlyWildcardConsumers and
gcWithOnlyWildcardConsumers flags being set. You added a test if
gcWithOnlyWildcardConsumers is true but we should also add a quick test where
both flags are true (easy enough to change in the policy and can probably just
reuse the same test). We should also verify there's a test somewhere that still
works for gc network consumers flag (i would hope so).
3. Verify that there's good GC test coverage with both flags false as the
default, i would expect there should already be some GC tests but I haven't
looked in a while.
I think better test coverage is important because it would be bad to start
deleting destinations that should not be deleted as that leads to permanent
data loss.
Issue Time Tracking
-------------------
Worklog Id: (was: 1001387)
Time Spent: 2h (was: 1h 50m)
> Support destination gc sweep of destinations with wild card consumers
> ---------------------------------------------------------------------
>
> Key: AMQ-9692
> URL: https://issues.apache.org/jira/browse/AMQ-9692
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Minor
> Fix For: 6.3.0, 5.19.2
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Currently, a wild-card consumer can hold up a destination from being
> automatically garbage collected. This change would add a policyEntry setting
> to allow garbage collection if the destination only has wild card consumers
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
