[jira] [Commented] (AIRAVATA-2657) Refactoring App Catalog implementation - ApplicationDeployment and ApplicationInterface

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/AIRAVATA-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390696#comment-16390696
 ] 

ASF GitHub Bot commented on AIRAVATA-2657:
------------------------------------------

tilaks26 commented on a change in pull request #167: [AIRAVATA-2657] 
Refactoring App Catalog Implementation - ApplicationDeployment and 
ApplicationInterface Modules
URL: https://github.com/apache/airavata/pull/167#discussion_r173057150
 
 

 ##########
 File path: 
modules/registry-refactoring/src/main/java/org/apache/airavata/registry/core/entities/appcatalog/ApplicationOutputEntity.java
 ##########
 @@ -20,123 +20,140 @@
 */
 package org.apache.airavata.registry.core.entities.appcatalog;
 
-import javax.persistence.Column;
-import javax.persistence.EmbeddedId;
-import javax.persistence.Entity;
-import javax.persistence.Table;
+import javax.persistence.*;
 import java.io.Serializable;
 
 /**
  * The persistent class for the application_output database table.
  */
 @Entity
-@Table(name = "application_output")
+@Table(name = "APPLICATION_OUTPUT")
+@IdClass(ApplicationOutputPK.class)
 public class ApplicationOutputEntity implements Serializable {
     private static final long serialVersionUID = 1L;
 
-    @EmbeddedId
-    private ApplicationOutputPK id;
+    @Id
+    @Column(name="INTERFACE_ID")
+    private String interfaceId;
+
+    @Id
+    @Column(name="OUTPUT_KEY")
+    private String name;
 
     @Column(name = "APP_ARGUMENT")
-    private String appArgument;
+    private String applicationArgument;
 
     @Column(name = "DATA_MOVEMENT")
-    private short dataMovement;
+    private boolean dataMovement;
 
     @Column(name = "DATA_NAME_LOCATION")
-    private String dataNameLocation;
+    private String location;
 
     @Column(name = "DATA_TYPE")
-    private String dataType;
+    private String type;
 
     @Column(name = "IS_REQUIRED")
-    private short isRequired;
+    private boolean isRequired;
 
     @Column(name = "OUTPUT_STREAMING")
-    private short outputStreaming;
+    private boolean outputStreaming;
 
     @Column(name = "OUTPUT_VALUE")
-    private String outputValue;
+    private String value;
 
     @Column(name = "REQUIRED_TO_COMMANDLINE")
-    private short requiredToCommandline;
+    private boolean requiredToAddedToCommandLine;
 
     @Column(name = "SEARCH_QUERY")
     private String searchQuery;
 
+    private String storageResourceId;
 
 Review comment:
   I didn't include a `@Column` annotation for this because there is no 
corresponding column in the APPLICATION_OUTPUT table for this attribute.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Refactoring App Catalog implementation - ApplicationDeployment and 
> ApplicationInterface
> ---------------------------------------------------------------------------------------
>
>                 Key: AIRAVATA-2657
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2657
>             Project: Airavata
>          Issue Type: Task
>          Components: Application Catalog
>            Reporter: Sneha Tilak
>            Assignee: Sneha Tilak
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)