[ 
https://issues.apache.org/jira/browse/AIRAVATA-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390770#comment-16390770
 ] 

ASF GitHub Bot commented on AIRAVATA-2657:
------------------------------------------

tilaks26 commented on a change in pull request #167: [AIRAVATA-2657] 
Refactoring App Catalog Implementation - ApplicationDeployment and 
ApplicationInterface Modules
URL: https://github.com/apache/airavata/pull/167#discussion_r173065990
 
 

 ##########
 File path: 
modules/registry-refactoring/src/main/java/org/apache/airavata/registry/core/entities/appcatalog/ApplicationInterfaceEntity.java
 ##########
 @@ -60,6 +60,10 @@
        @Column(name="HAS_OPTIONAL_FILE_INPUTS")
        private boolean hasOptionalFileInputs;
 
+       @ElementCollection
+       @CollectionTable(name="APPLICATION_MODULE", joinColumns = 
@JoinColumn(name="MODULE_ID"))
+       private List<String> applicationModules;
 
 Review comment:
   @machristie There is no corresponding column for this attribute in the 
APPLICATION_INTERFACE table. Also, it is of List<String> type. Can you please 
verify if the `@ElementCollection` annotation required here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Refactoring App Catalog implementation - ApplicationDeployment and 
> ApplicationInterface
> ---------------------------------------------------------------------------------------
>
>                 Key: AIRAVATA-2657
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2657
>             Project: Airavata
>          Issue Type: Task
>          Components: Application Catalog
>            Reporter: Sneha Tilak
>            Assignee: Sneha Tilak
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to