[
https://issues.apache.org/jira/browse/AIRAVATA-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411984#comment-16411984
]
ASF GitHub Bot commented on AIRAVATA-2657:
------------------------------------------
machristie commented on a change in pull request #167: [AIRAVATA-2657]
Refactoring App Catalog Implementation - ApplicationDeployment and
ApplicationInterface Modules
URL: https://github.com/apache/airavata/pull/167#discussion_r176851411
##########
File path:
modules/registry/registry-server/registry-api-service/src/main/java/org/apache/airavata/registry/api/service/handler/RegistryServerHandler.java
##########
@@ -3589,8 +3586,7 @@ public String registerApplicationDeployment(String
gatewayId, ApplicationDeploym
@Override
public boolean updateApplicationModule(String appModuleId,
ApplicationModule applicationModule) throws RegistryServiceException,
TException {
try {
- appCatalog = RegistryFactory.getAppCatalog();
-
appCatalog.getApplicationInterface().updateApplicationModule(appModuleId,
applicationModule);
+ new
ApplicationInterfaceRepository().updateApplicationModule(appModuleId,
applicationModule);
Review comment:
My understanding is that we can reuse them since they are stateless and
hence threadsafe. +1 for just instantiating these once in RegistryServerHandler
and reusing them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactoring App Catalog implementation - ApplicationDeployment and
> ApplicationInterface
> ---------------------------------------------------------------------------------------
>
> Key: AIRAVATA-2657
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2657
> Project: Airavata
> Issue Type: Task
> Components: Application Catalog
> Reporter: Sneha Tilak
> Assignee: Sneha Tilak
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
