[
https://issues.apache.org/jira/browse/AIRAVATA-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411632#comment-16411632
]
ASF GitHub Bot commented on AIRAVATA-2657:
------------------------------------------
DImuthuUpe commented on issue #167: [AIRAVATA-2657] Refactoring App Catalog
Implementation - ApplicationDeployment and ApplicationInterface Modules
URL: https://github.com/apache/airavata/pull/167#issuecomment-375716872
@tilaks26 Code looks good. There are few areas that need improvements
Add more debug or info level logs in the complex if conditions. This will
benefit when we are doing debugging.
Improve the readability of the code. One option is to add new lines
logically when there are too much lines together.
Do null checks and the availability to the items in the lists before
accessing them. Handle them properly and always try to avoid
NullPointerExceptions.
@machristie @sachinkariyattin @tilaks26 I do not have a in depth idea of
what is going inside the registry refactoring. Do we have any resource that we
can refer in order to have an idea of the proposed changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactoring App Catalog implementation - ApplicationDeployment and
> ApplicationInterface
> ---------------------------------------------------------------------------------------
>
> Key: AIRAVATA-2657
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2657
> Project: Airavata
> Issue Type: Task
> Components: Application Catalog
> Reporter: Sneha Tilak
> Assignee: Sneha Tilak
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
