isururanawaka commented on code in PR #290:
URL: https://github.com/apache/airavata-custos/pull/290#discussion_r941735908


##########
ansible/env_setup.yml:
##########
@@ -0,0 +1,30 @@
+#

Review Comment:
   Any reason to have this as a separate target instead of role



##########
ansible/inventories/test/group_vars/all/vars.yml:
##########
@@ -0,0 +1,148 @@
+#
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+---
+ansible_connection: ssh
+
+user: exouser
+group: exouser
+user_home: "/home/{{ user }}"
+
+# Domain names for VMs
+keycloak_domain: bm-dev-2.usecustos.org

Review Comment:
   substitute these values from hosts file



##########
ansible/roles/custos/templates/custos-integration-services/application.properties.j2:
##########
@@ -0,0 +1,37 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+#  specific language governing permissions and limitations
+#  under the License.
+#
+
+grpc.port=7070
+server.port=8080
+##spring.zipkin.baseUrl=http://149.165.169.49:9411/
+spring.application.name=custos-integrations-services-server
+##spring.sleuth.sampler.probability=1
+spring.main.allow-bean-definition-overriding=true
+management.security.enabled=false
+management.endpoints.web.exposure.include=*
+management.endpoint.metrics.enabled=true
+spring.jmx.enabled=true
+
+spring.profiles.active=dev
+logging.level.root=INFO
+
+core.services.server.port=7071
+core.services.server.hostname=localhost
+iam.server.url=https://bm-dev-2.usecustos.org/auth//auth/

Review Comment:
   substitute  from  variables



##########
ansible/inventories/test/host_vars/keycloak/vars.yml:
##########
@@ -0,0 +1,26 @@
+#
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+---
+domain: "{{ keycloak_domain }}"
+pkcs12_filename: 'keycloak-client-truststore.pkcs12'
+pkcs12_passphrase: "{{ keycloak_pkcs12_passphrase }}"
+ansible_ssh_password: "{{ keycloak_ssh_password }}"
+nginx_site_config: bm-dev-2.usecustos.org.j2

Review Comment:
   these are need to be variables



##########
ansible/inventories/test/group_vars/all/vars.yml:
##########
@@ -0,0 +1,148 @@
+#
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+---
+ansible_connection: ssh
+
+user: exouser
+group: exouser
+user_home: "/home/{{ user }}"
+
+# Domain names for VMs
+keycloak_domain: bm-dev-2.usecustos.org
+hashicorp_domain: bm-dev-3.usecustos.org
+custos_domain: bm-dev-1.usecustos.org
+
+# ssh passwords for VMs
+keycloak_ssh_password: !vault |
+  $ANSIBLE_VAULT;1.1;AES256
+  
36363039363662616335356566613665346161396138303131616334616666623361633765356434
+  
3234326462633763636563343562656264376366623631310a363030326163393336643663323631
+  
33626432663465646262373661383362623038623238383462356334633063363961303130623630
+  
3832616438366637340a386639396561616161393033626363613964393137353665356630636330
+  
38613661313031366135303033303538646561326232313466646139316366393566633734376363
+  
35303164623261343532366330633730353266306631363863356631623261613336313832303433
+  363238623135326235396536643161313064
+hashicorp_ssh_password: !vault |
+  $ANSIBLE_VAULT;1.1;AES256
+  
62633531346536643234303565373639626464326135653732323266396335353166346132383230
+  
3333316665623861326164653162393361666665376466390a356535613332333838303037323535
+  
61636665633334646564323336376363656464396466613535646666373033336336356562323032
+  
6539363064373966300a303137666237613065326635643630326438646162326663363732303431
+  
66333562666232376133643661336264356637636335323630313339343231306431616538363439
+  
65626635323634653866636438663738626165366261363333313736386238373933343230386236
+  333266663739323034626462353738656662
+custos_ssh_password: !vault |
+  $ANSIBLE_VAULT;1.1;AES256
+  
64356232636232646134616539663065393435386163373736366231373736326136663436316337
+  
3538366264623564343862653330373238376161643232320a323935376361376362386432626330
+  
62323464646334613231613664353963666362313133393937623430396132646364316264613061
+  
3062343230636137370a353138333038636631303366653763636631313739623637363039356561
+  
37643230623134303132343231613364383036353437643064636663653366306133376338623235
+  
61613138373934653036643735323432313336646131336266386565376532333533383430663537
+  376666653633346237353065626463633330
+
+# pkcs12 passwords
+hashicorp_pkcs12_passphrase: !vault |
+  $ANSIBLE_VAULT;1.1;AES256
+  
65646665313232613265363038633662393438376265663363333434303361656565653763313539
+  
3937356538373262333031333463346338666538623566610a353232353565353566653564313239
+  
37333962393564346261343837646564333737636637613861313532666431333136383836626539
+  
6630353236613838340a383863333366383938353662356366333833393761383935663837353037
+  6537
+keycloak_pkcs12_passphrase: !vault |
+  $ANSIBLE_VAULT;1.1;AES256
+  
63303962613033353165646639633338306538666233363735393266386432376663656536633663
+  
6231316333363164383230303239366537366365346236620a396463313838373937653264343165
+  
61363964376534616137653764303034616433626539306563333536316433396562353337646631
+  
3536616534633033650a343730636632343764343834303933336266653063616335313962333137
+  64373562643465653532323839613237383762383637326332396330613831303961
+# deployment related variables
+custos_deployment_dir: "{{ user_home }}/custos-deployment"
+custos_source_dir: "{{ user_home }}/custos-source"
+#custos_repo: "https://github.com/apache/airavata-custos.git";
+custos_repo: "https://github.com/abhinav7sinha/airavata-custos.git";

Review Comment:
   point this to  main repo



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to