[
https://issues.apache.org/jira/browse/AMBARI-19149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965809#comment-15965809
]
Hudson commented on AMBARI-19149:
---------------------------------
FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #7275 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/7275/])
AMBARI-19149. Code cleanup: redundant modifiers (interfaces, enums)
(adoroszlai:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=754d6c8723e577ded6adc2448730a3c7ead8f7a2])
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/PageRequest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/QueryResponse.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/persistence/SchemaManagerFactory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationInfo.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/JPATableGenerationStrategy.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceHandlerList.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/RequestHandler.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/Operator.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/PredicateVisitor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/CommandScriptDefinition.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/expressions/Expression.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintFactory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourcePredicateEvaluator.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/Config.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/ivory/IvoryService.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricHostProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/jdbc/ConnectionFactory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/ResourceType.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerStateProvider.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/upgrade/SectionDDL.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/action/Action.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/tasks/TopologyTask.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroup.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/PageResponse.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ProviderModule.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/HostHealthStatus.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ExtendedResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/PropertyProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionJob.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPaddingMethod.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/RequestStatus.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultStatus.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Schema.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultPostProcessor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Predicate.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/cache/HostConfigMapping.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/SecurityHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroup.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/fsm/SingleArcTransition.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/PredicateVisitorAcceptor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyValidator.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/RelationalOperator.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/RequestExecution.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/Validable.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequestFactory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/SchemaFactory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/util/TreeNode.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeFunction.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCallback.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/fsm/MultipleArcTransition.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstance.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ObservableResourceProvider.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractJDBCResourceProviderTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ResourceProviderObserver.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManager.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/encryption/MasterKeyService.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduler.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandType.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionModule.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnable.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsServiceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfiguration.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/BasePredicate.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/LogicalOperator.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosConfigDataFile.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/SortRequest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/query/render/Renderer.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/StreamProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/cache/ConfigGroupHostMapping.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/fsm/StateMachine.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java
> Clean up Ambari Server source code warnings
> -------------------------------------------
>
> Key: AMBARI-19149
> URL: https://issues.apache.org/jira/browse/AMBARI-19149
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Fix For: 3.0.0
>
> Attachments: AMBARI-19149-10.patch, AMBARI-19149-1.patch,
> AMBARI-19149-3.patch, AMBARI-19149-4.patch, AMBARI-19149-5.patch,
> AMBARI-19149-6.patch, AMBARI-19149-7.patch, AMBARI-19149-9.patch,
> IDEA_Ambari_v1.xml
>
>
> Eclipse's default warnings generated for {{ambari-server}} number roughly
> over 3300. Out of these, at least half of them are:
> * Unused imports
> * Type safety due to forgotten {{<>}}
> * Missing Serialization IDs from anonymous {{HashMap}} implementations
> * Unused variables
> * {{Capture<T>}} in tests
> * {{switch}} fall-through and missing {{case statements}}: *only makes
> changes which won't affect existing functionality*
> This makes spotting actual problems, like missing {{case}} statements a
> nightmare. We need to go through and clean out as many of these warnings as
> possible.
> Note: With respect to the import cleanup, the IDE of choice should have the
> following import order setup. They should always be expanded and never use
> {{*}}.
> # {{java}}
> # {{javax}}
> # {{org}}
> # {{com}}
> # other
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
