[
https://issues.apache.org/jira/browse/AMBARI-19149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972660#comment-15972660
]
Hudson commented on AMBARI-19149:
---------------------------------
SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #7311 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/7311/])
AMBARI-19149. Code cleanup: unresolved references in javadoc (adoroszlai:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=8e2abf97bd2f10bad978d176a53bffd0ad2c7b67])
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionDisabledEvent.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionDAO.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/rest/BootStrapResource.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/query/JpaSortBuilder.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/events/jpa/EntityManagerCacheInvalidationEvent.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RequestScheduleResourceDefinition.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAOTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DbmsHelper.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewURLEntity.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/services/MetricsRetrievalService.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/api/query/JpaSortBuilderTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupFactory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeGroupEntity.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/fsm/StateMachineFactory.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapper.java
> Clean up Ambari Server source code warnings
> -------------------------------------------
>
> Key: AMBARI-19149
> URL: https://issues.apache.org/jira/browse/AMBARI-19149
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Fix For: 3.0.0
>
> Attachments: AMBARI-19149-10.patch, AMBARI-19149-11.patch,
> AMBARI-19149-1.patch, AMBARI-19149-3.patch, AMBARI-19149-4.patch,
> AMBARI-19149-5.patch, AMBARI-19149-6.patch, AMBARI-19149-7.patch,
> AMBARI-19149-9.patch, IDEA_Ambari_v1.xml
>
>
> Eclipse's default warnings generated for {{ambari-server}} number roughly
> over 3300. Out of these, at least half of them are:
> * Unused imports
> * Type safety due to forgotten {{<>}}
> * Missing Serialization IDs from anonymous {{HashMap}} implementations
> * Unused variables
> * {{Capture<T>}} in tests
> * {{switch}} fall-through and missing {{case statements}}: *only makes
> changes which won't affect existing functionality*
> This makes spotting actual problems, like missing {{case}} statements a
> nightmare. We need to go through and clean out as many of these warnings as
> possible.
> Note: With respect to the import cleanup, the IDE of choice should have the
> following import order setup. They should always be expanded and never use
> {{*}}.
> # {{java}}
> # {{javax}}
> # {{org}}
> # {{com}}
> # other
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
