[
https://issues.apache.org/jira/browse/AMBARI-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069825#comment-16069825
]
ASF GitHub Bot commented on AMBARI-21365:
-----------------------------------------
GitHub user xiemaisi opened a pull request:
https://github.com/apache/ambari/pull/59
AMBARI-21365: Add a few missing `var` declarations.
This fixes some minor issues found by [lgtm](https://lgtm.com); for more
details see https://lgtm.com/projects/g/apache/ambari/alerts/. (Full
disclosure: I work on the JavaScript analysis behind lgtm.)
I've already filed a JIRA issue for this with patch attached
(https://issues.apache.org/jira/browse/AMBARI-21365), but it's not been picked
up yet.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiemaisi/ambari fix-lgtm-alerts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ambari/pull/59.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #59
----
----
> Accidental globals in JavaScript code
> -------------------------------------
>
> Key: AMBARI-21365
> URL: https://issues.apache.org/jira/browse/AMBARI-21365
> Project: Ambari
> Issue Type: Improvement
> Components: contrib
> Affects Versions: trnk
> Reporter: Max Schaefer
> Priority: Minor
> Attachments: AMBARI-21365.patch
>
>
> As detected by [lgtm|https://lgtm.com], a few JavaScript variables are used
> like local variables but are missing declarations, meaning that they become
> globals by default. This seems unlikely to be intentional, and is fixed by
> the attached patch.
> For more details see https://lgtm.com/projects/g/apache/ambari/alerts. (Full
> disclosure: I work on the JavaScript analysis behind lgtm.)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
