[
https://issues.apache.org/jira/browse/AMBARI-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076076#comment-16076076
]
Max Schaefer commented on AMBARI-21365:
---------------------------------------
> 1 tests included. The patch doesn't appear to include any new or modified
> tests.
> Please justify why no new tests are needed for this patch.
The patch does not change behaviour, so there is no point in adding new tests.
> Also please list what manual steps were performed to verify this patch.
Code inspection revealed that the variables in question are treated as local
variables, hence explicitly declaring them that way is behaviour preserving.
> Accidental globals in JavaScript code
> -------------------------------------
>
> Key: AMBARI-21365
> URL: https://issues.apache.org/jira/browse/AMBARI-21365
> Project: Ambari
> Issue Type: Improvement
> Components: contrib
> Affects Versions: trnk
> Reporter: Max Schaefer
> Priority: Minor
> Attachments: AMBARI-21365.patch
>
>
> As detected by [lgtm|https://lgtm.com], a few JavaScript variables are used
> like local variables but are missing declarations, meaning that they become
> globals by default. This seems unlikely to be intentional, and is fixed by
> the attached patch.
> For more details see https://lgtm.com/projects/g/apache/ambari/alerts. (Full
> disclosure: I work on the JavaScript analysis behind lgtm.)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
