shuashuai commented on code in PR #1424:
URL: https://github.com/apache/answer/pull/1424#discussion_r2521989613
##########
ui/src/components/SchemaForm/components/Input.tsx:
##########
@@ -29,6 +29,17 @@ interface Props {
onChange?: (fd: Type.FormDataType) => void;
formData: Type.FormDataType;
readOnly: boolean;
+ minValue?: number;
+ inputMode?:
+ | 'text'
+ | 'search'
+ | 'none'
+ | 'tel'
+ | 'url'
+ | 'email'
+ | 'numeric'
+ | 'decimal'
+ | undefined;
}
Review Comment:
1. Just added the relevant TypeScript types inside the input component.
2. Missing relevant TypeScript definitions in
SchemaForm(`/ui/src/components/SchemaForm/types.ts`), So there will be a
TypeScript error when generating forms through configuration. You can conduct
relevant tests in `ui/src/pages/Admin/Smtp/index.tsx`
eg:
<img width="583" height="481" alt="image"
src="https://github.com/user-attachments/assets/1fe2efd3-8856-4363-a5e5-dd243bcb0e8e";
/>
3. According to the requirement description, it is also necessary to support
the max attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
