Dinesht04 commented on code in PR #1424:
URL: https://github.com/apache/answer/pull/1424#discussion_r2541313760
##########
ui/src/components/SchemaForm/components/Input.tsx:
##########
@@ -60,6 +75,9 @@ const Index: FC<Props> = ({
placeholder={placeholder}
type={type}
value={fieldObject?.value || ''}
+ min={min}
+ max={max}
+ inputMode={inputMode}
Review Comment:
I didn't even know you could conditionally pass props in this manner. Thank
you so much. I agree with the max value point.
Could please guide me whether I should combine all the changes into a single
commit or is it okay if I have multiple commits, I am unaware of what's the
best practice. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
