[ 
http://jira.codehaus.org/browse/MRM-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=226128#action_226128
 ] 

Brett Porter commented on MRM-980:
----------------------------------

For the patch so far, per my comments on dev@, I think this could be pushed 
into the MetadataRepository interface instead of here. The merge should provide 
something like a RepositoryMerger or RepositoryArtifactCopier interface instead.

Some more general comments on the patch:
- there's no need to use the ArchivaArtifact class - that's something that 
we're in the process of removing in favour of the content model
- while either is fine, you might prefer to use Mockito for mocking objects for 
tests
- the POM here has more dependencies than necessary - watch this carefully

> Ability to merge repositories
> -----------------------------
>
>                 Key: MRM-980
>                 URL: http://jira.codehaus.org/browse/MRM-980
>             Project: Archiva
>          Issue Type: New Feature
>            Reporter: Wendy Smoak
>             Fix For: Backlog
>
>         Attachments: SourceAritfacts.java, stage-repository-merge.patch, 
> stage-repository-merge.patch, stage-repository-merge.patch, 
> stage-repository-merge.patch, stage-repository-merge.patch, 
> stage-repository-merge.zip
>
>
> Need to be able to merge one repository into another, updating metadata and 
> not overwriting existing artifacts.
> The source repository should remain unchanged.
> It should produce output listing what was merged and what wasn't.
> Additions to the target repo should show in the audit log.
> Related thread:  http://www.nabble.com/Merging-repositories-ts19850359.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to