[
http://jira.codehaus.org/browse/MRM-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=226320#action_226320
]
Maria Odea Ching commented on MRM-980:
--------------------------------------
Hi Eshan, here are my comments on the ArtifactsMerger class you've attached:
* the name of the method isArtifactAvailableIntagerRepo(ArchivaArtifact
artifact) should be fixed to isArtifactAvailableInTargetRepo(..)
* you'll have a problem in line 187 & 188, POM files are deployed as *.pom in
the repo
* avoid using UPPER CASE for the first letter of a variable name (convention is
using small case for the first letter/word for variable names). See below:
{code}
File SourceArtifactFile = new File(sourceRepoPath , artifactPath);
//line 168
File TargetArtifactFile = new File(targetRepoPath , artifactPath);
//line 170
{code}
* in the method createFolderStructure(ArchivaArtifact artifact), you shouldn't
be accessing the metadata.xml files because the merger shouldn't know about the
layout/type of the repository. See Brett's comment regarding that in the dev
list thread with subj: [GSoC] Staging repositories updates
> Ability to merge repositories
> -----------------------------
>
> Key: MRM-980
> URL: http://jira.codehaus.org/browse/MRM-980
> Project: Archiva
> Issue Type: New Feature
> Reporter: Wendy Smoak
> Fix For: Backlog
>
> Attachments: ArtifactsMerger.java, ArtifactsMerger.java,
> SourceAritfacts.java, stage-repository-merge.patch,
> stage-repository-merge.patch, stage-repository-merge.patch,
> stage-repository-merge.patch, stage-repository-merge.patch,
> stage-repository-merge.zip
>
>
> Need to be able to merge one repository into another, updating metadata and
> not overwriting existing artifacts.
> The source repository should remain unchanged.
> It should produce output listing what was merged and what wasn't.
> Additions to the target repo should show in the audit log.
> Related thread: http://www.nabble.com/Merging-repositories-ts19850359.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
