[ 
https://issues.apache.org/jira/browse/ARIA-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106564#comment-16106564
 ] 

Tal Liron commented on ARIA-333:
--------------------------------

I think #2 is the important one.

Perhaps we can strip support for unpacking {{.value}} and have instrumentation 
focused solely on event triggers? This would make this complex code easier to 
understand and maintain.

> Remove model instrumentation code
> ---------------------------------
>
>                 Key: ARIA-333
>                 URL: https://issues.apache.org/jira/browse/ARIA-333
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Tal Liron
>
> Our model instrumentation code is some of the most complex part of our 
> codebase. It is difficult to understand and maintain.
> Why do we have this complex mechanism? Because we want it to be easier to 
> access values in parameters dicts without having to add {{.value}}.
> In the case of the ctx proxy, there is a much simpler solution. We could just 
> check if the final value is a {{models.Parameter}}, and if so unpack the 
> value from it.
> For uses of ctx within Python there indeed is no simple solution. However, in 
> my opinion the solution we chose is far too complex, and the cons far 
> outweigh the pros.
> In the end, it's really seems not too much to expect a Python programmer to 
> add {{.value}} where necessary.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to