[
https://issues.apache.org/jira/browse/ARIA-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106883#comment-16106883
]
Maxim Orlov commented on ARIA-333:
----------------------------------
Using sqlalchemy events was indeed considered, there are two main issues with
this:
1. from experience the usage of the sqlalcehmy event mechanism leads to
somewhat hard to follow code.
2. it might be problematic (but not necessarily) with this approach is that
through out the entire use of context/model storage this behavior will be
triggered, i.e. no explicit model creation throughout the code (maybe it is the
behavior we want).
> Remove model instrumentation code
> ---------------------------------
>
> Key: ARIA-333
> URL: https://issues.apache.org/jira/browse/ARIA-333
> Project: AriaTosca
> Issue Type: Story
> Reporter: Tal Liron
>
> Our model instrumentation code is some of the most complex part of our
> codebase. It is difficult to understand and maintain.
> Why do we have this complex mechanism? Because we want it to be easier to
> access values in parameters dicts without having to add {{.value}}.
> In the case of the ctx proxy, there is a much simpler solution. We could just
> check if the final value is a {{models.Parameter}}, and if so unpack the
> value from it.
> For uses of ctx within Python there indeed is no simple solution. However, in
> my opinion the solution we chose is far too complex, and the cons far
> outweigh the pros.
> In the end, it's really seems not too much to expect a Python programmer to
> add {{.value}} where necessary.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
