[
https://issues.apache.org/jira/browse/ARROW-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164458#comment-16164458
]
ASF GitHub Bot commented on ARROW-1134:
---------------------------------------
GitHub user TobyShaw opened a pull request:
https://github.com/apache/arrow/pull/1098
ARROW-1134 - Allow C++/CLI projects to build with Arrow
I'm going to attempt a few things:
In public headers:
Hide mutexes through pimpl pattern.
Replace nullptr with __nullptr when building in C++/CLI mode.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TobyShaw/arrow master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/arrow/pull/1098.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1098
----
commit d8cb1f676452af940bbc963c43ab3c5809d85459
Author: labuser <labuser@labwks10>
Date: 2017-09-13T10:34:21Z
Attempt PImpl on FixedSizeBufferWriter
commit d1903d7aa768a27e304c3f00d59cb725dfddf0f2
Author: labuser <labuser@labwks10>
Date: 2017-09-13T10:35:29Z
remove mutex include
----
> [C++] Allow C++/CLI projects to build with Arrow
> -------------------------------------------------
>
> Key: ARROW-1134
> URL: https://issues.apache.org/jira/browse/ARROW-1134
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Toby Shaw
> Priority: Minor
> Labels: pull-request-available
>
> Currently, the inclusion of <mutex> in some of Arrow's C++ headers prevents
> C++/CLI code from building against it.
> From a C++/CLI project:
> #include <arrow/io/file.h>
> ...
> "#error directive: <mutex> is not supported when compiling with /clr or
> /clr:pure."
> This could be patched by optionally relying on Boost's mutex/lock_guard
> instead of std, or not exposing the #include <mutex> publically.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
