[
https://issues.apache.org/jira/browse/ARROW-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213653#comment-16213653
]
ASF GitHub Bot commented on ARROW-1134:
---------------------------------------
GitHub user wesm opened a pull request:
https://github.com/apache/arrow/pull/1228
ARROW-1134: [C++] Support for C++/CLI compilation, add NULLPTR define to
avoid using nullptr in public headers
cc @tobyshaw. Can you test this?
Close #1098
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wesm/arrow ARROW-1134
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/arrow/pull/1228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1228
----
commit 4b4ca46ad0cdad4ca5aa804a9cd309c540059c0b
Author: Wes McKinney <wes.mckin...@twosigma.com>
Date: 2017-10-21T01:48:33Z
Add NULLPTR macro to avoid using nullptr in public headers for C++/CLI users
Change-Id: Id8ef2be3f293a5fbb1cc6e5b792b25b9391bcf6b
----
> [C++] Allow C++/CLI projects to build with Arrow
> -------------------------------------------------
>
> Key: ARROW-1134
> URL: https://issues.apache.org/jira/browse/ARROW-1134
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Toby Shaw
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Currently, the inclusion of <mutex> in some of Arrow's C++ headers prevents
> C++/CLI code from building against it.
> From a C++/CLI project:
> #include <arrow/io/file.h>
> ...
> "#error directive: <mutex> is not supported when compiling with /clr or
> /clr:pure."
> This could be patched by optionally relying on Boost's mutex/lock_guard
> instead of std, or not exposing the #include <mutex> publically.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
