[
https://issues.apache.org/jira/browse/ARROW-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183093#comment-16183093
]
ASF GitHub Bot commented on ARROW-1619:
---------------------------------------
GitHub user BryanCutler opened a pull request:
https://github.com/apache/arrow/pull/1140
ARROW-1619: [Java] Set lastSet in JsonFileReader
When reading a vector in JsonFileReader, lastSet should be set in
VariableWidthVectors after reading inner vectors or else subsequent operations
could corrupt the offsets. This also allows to simplify some of the related
code. Additionally, ListVector.lastSet should be explicitly initialized to 0,
which is it's starting offset.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BryanCutler/arrow
java-JsonReader-setLast-ARROW-1619
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/arrow/pull/1140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1140
----
commit 70df0cc402b47f41fc1b31bdcf4b3ba0c532e063
Author: Bryan Cutler <[email protected]>
Date: 2017-09-27T18:51:57Z
set lastSet in JsonFileReader and initialize lastSet for ListVector
----
> [Java] Correctly set "lastSet" for variable vectors in JsonReader
> -----------------------------------------------------------------
>
> Key: ARROW-1619
> URL: https://issues.apache.org/jira/browse/ARROW-1619
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java - Vectors
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Labels: pull-request-available
>
> The Arrow Java JsonFileReader does not correctly set "lastSet" in
> VariableWidthVectors which makes reading inner vectors overly complicated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
