[ 
https://issues.apache.org/jira/browse/ARROW-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184639#comment-16184639
 ] 

ASF GitHub Bot commented on ARROW-1619:
---------------------------------------

Github user BryanCutler commented on the issue:

    https://github.com/apache/arrow/pull/1140
  
    > can you add a test for this issue? 
    
    I think the real test for this is that you can call `setValueCount` on the 
vector at the end and it won't fill it with empty values for the VarChar/Binary 
cases or corrupt the offset vector for ListVector.  The existing JSON tests 
cover this pretty well, but looks like there's nothing for VarBinaryVector so I 
can add that.


> [Java] Correctly set "lastSet" for variable vectors in JsonReader
> -----------------------------------------------------------------
>
>                 Key: ARROW-1619
>                 URL: https://issues.apache.org/jira/browse/ARROW-1619
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java - Vectors
>            Reporter: Bryan Cutler
>            Assignee: Bryan Cutler
>              Labels: pull-request-available
>
> The Arrow Java JsonFileReader does not correctly set "lastSet" in 
> VariableWidthVectors which makes reading inner vectors overly complicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to