[
https://issues.apache.org/jira/browse/ARROW-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190499#comment-16190499
]
ASF GitHub Bot commented on ARROW-1525:
---------------------------------------
GitHub user amirma opened a pull request:
https://github.com/apache/arrow/pull/1156
ARROW-1525: [C++] New compare functions that return boolean instead of
Status
Comparison should always succeed so, it makes better sense to return boolean
values as the result of comparison instead of Status.
This changeset introduces a set of new compare functions and deprecates the
current ones.
Author: Amir Malekpour <[email protected]>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amirma/arrow arrow-1525
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/arrow/pull/1156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1156
----
commit 7279e09967b7d274ec9b5dc3d45a59f9c1623669
Author: Amir Malekpour <[email protected]>
Date: 2017-10-02T22:44:37Z
ARROW-1525: [C++] New compare functions that return boolean instead of
Status
Comparison should always succeed so, it makes better sense to return boolean
values as the result of comparison instead of Status.
This changeset introduces a set of new compare functions and deprecates the
current ones.
Author: Amir Malekpour <[email protected]>
----
> [C++] Change functions in arrow/compare.h to not return Status
> --------------------------------------------------------------
>
> Key: ARROW-1525
> URL: https://issues.apache.org/jira/browse/ARROW-1525
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Amir Malekpour
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> It should not be possible for these functions to fail. Internal failures
> indicate a problem with the implementation rather than the input data, and
> any such problems should be caught by a debug assertion in the test suite
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
