[ 
https://issues.apache.org/jira/browse/ARROW-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192300#comment-16192300
 ] 

ASF GitHub Bot commented on ARROW-1525:
---------------------------------------

Github user wesm commented on the issue:

    https://github.com/apache/arrow/pull/1156
  
    +1. Here's the queued Appveyor build (we've recently had an issue with the 
hook not working properly): 
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/build/1.0.3632. 
I will return back and merge once this build passes. 


> [C++] Change functions in arrow/compare.h to not return Status
> --------------------------------------------------------------
>
>                 Key: ARROW-1525
>                 URL: https://issues.apache.org/jira/browse/ARROW-1525
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Amir Malekpour
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>
> It should not be possible for these functions to fail. Internal failures 
> indicate a problem with the implementation rather than the input data, and 
> any such problems should be caught by a debug assertion in the test suite



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to