[ 
https://issues.apache.org/jira/browse/ARROW-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191711#comment-16191711
 ] 

ASF GitHub Bot commented on ARROW-1613:
---------------------------------------

Github user BryanCutler commented on the issue:

    https://github.com/apache/arrow/pull/1138
  
    It sounds like this could possibly be too disruptive, so I will change to 
add an alternate `close(boolean closeReadChannel)` that can close resources 
without the input stream, and `close()` will keep the same behavior.


> [Java] ArrowReader should not close the input ReadChannel
> ---------------------------------------------------------
>
>                 Key: ARROW-1613
>                 URL: https://issues.apache.org/jira/browse/ARROW-1613
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java - Vectors
>            Reporter: Bryan Cutler
>            Assignee: Bryan Cutler
>              Labels: pull-request-available
>
> Currently, {{ArrowReader.close()}} will close resources (VectorSchemaRoot and 
> Dictionary Vectors) and also close the input ReadChannel, or InputStream for 
> ArrowStreamReader.  Closing of the ReadChannel should be done by what ever 
> created it because it might need to be reused.
> If this not possible, an alternative could be to add a method 
> {{ArrowReader.end()}} that will close resources but not the ReadChannel.  
> Then {{end()}} could be called instead of {{close()}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to