[
https://issues.apache.org/jira/browse/ARROW-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192998#comment-16192998
]
ASF GitHub Bot commented on ARROW-1613:
---------------------------------------
Github user icexelloss commented on the issue:
https://github.com/apache/arrow/pull/1138
From an API point of view, I kind of prefer having something like
`finish()` rather than `close()`
The reason being `close()` have a pretty well defined semantics in most
java io libraries and have a parameter to it might be weird. `finish()` kind of
make sense because it (the reader) finishes reading.
> [Java] ArrowReader should not close the input ReadChannel
> ---------------------------------------------------------
>
> Key: ARROW-1613
> URL: https://issues.apache.org/jira/browse/ARROW-1613
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Java - Vectors
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Priority: Minor
> Labels: pull-request-available
>
> Currently, {{ArrowReader.close()}} will close resources (VectorSchemaRoot and
> Dictionary Vectors) and also close the input ReadChannel, or InputStream for
> ArrowStreamReader. Closing of the ReadChannel should be done by what ever
> created it because it might need to be reused.
> If this not possible, an alternative could be to add a method
> {{ArrowReader.end()}} that will close resources but not the ReadChannel.
> Then {{end()}} could be called instead of {{close()}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
