[ 
https://issues.apache.org/jira/browse/ARROW-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214526#comment-16214526
 ] 

ASF GitHub Bot commented on ARROW-1474:
---------------------------------------

icexelloss commented on a change in pull request #1203: ARROW-1474:[WIP] Java 
Vector Refactor (Implementation Phase 2)
URL: https://github.com/apache/arrow/pull/1203#discussion_r146154853
 
 

 ##########
 File path: 
java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java
 ##########
 @@ -55,14 +58,12 @@ public static ListVector empty(String name, 
BufferAllocator allocator) {
     return new ListVector(name, allocator, 
FieldType.nullable(ArrowType.List.INSTANCE), null);
   }
 
-  final UInt4Vector offsets;
-  final BitVector bits;
-  private final List<BufferBacked> innerVectors;
-  private Mutator mutator = new Mutator();
-  private Accessor accessor = new Accessor();
+  private ArrowBuf validityBuffer;
 
 Review comment:
   Ok. This is fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [JAVA] ValueVector hierarchy (Implementation Phase 2)
> -----------------------------------------------------
>
>                 Key: ARROW-1474
>                 URL: https://issues.apache.org/jira/browse/ARROW-1474
>             Project: Apache Arrow
>          Issue Type: Sub-task
>            Reporter: Jacques Nadeau
>            Assignee: Siddharth Teotia
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to