[
https://issues.apache.org/jira/browse/ARROW-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214546#comment-16214546
]
ASF GitHub Bot commented on ARROW-1474:
---------------------------------------
icexelloss commented on a change in pull request #1203: ARROW-1474:[WIP] Java
Vector Refactor (Implementation Phase 2)
URL: https://github.com/apache/arrow/pull/1203#discussion_r146156364
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/BaseValueVector.java
##########
@@ -137,10 +136,19 @@ protected ArrowBuf releaseBuffer(ArrowBuf buffer) {
return buffer;
}
+ @Override
public int getValueCount() { return 0; }
+ @Override
public void setValueCount(int valueCount) { }
+ @Override
public Object getObject(int index) { return null; }
+
+ @Override
+ public int getNullCount() { return 0; }
Review comment:
I am concerned these methods would be confusing to user, so if we have to
keep them, I think we should make it clear these function won't work and
shouldn't be called at all. Maybe have a noisy deprecation warning or sth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [JAVA] ValueVector hierarchy (Implementation Phase 2)
> -----------------------------------------------------
>
> Key: ARROW-1474
> URL: https://issues.apache.org/jira/browse/ARROW-1474
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Jacques Nadeau
> Assignee: Siddharth Teotia
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
