[
https://issues.apache.org/jira/browse/ARROW-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215120#comment-16215120
]
ASF GitHub Bot commented on ARROW-1474:
---------------------------------------
wesm commented on issue #1203: ARROW-1474:[WIP] Java Vector Refactor
(Implementation Phase 2)
URL: https://github.com/apache/arrow/pull/1203#issuecomment-338656053
> For future reference, I usually prefer not to squash commit during PR -
this makes it hard to track incremental changes. We can squash commit when
merging.
We're really running into a weakness of GitHub code reviews. My
understanding is that Dremio uses Gerrit for code reviews (like Kudu, Impala,
and lots of Google projects) and so the squashing is a key part of the Gerrit
workflow. But it works pretty poorly for GitHub, where having a string of new
commits is better (although the GitHub UI is terrible for reviewing incremental
diffs)
I would really like to have the option of doing large Arrow code reviews on
Gerrit. It can be a bit challenging to do (because Gerrit can fall out of sync)
unless you have 100% of your reviews hosted on there, and Gerrit is quite a bit
of process for some users. I hope that we find a way to do this in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JAVA] ValueVector hierarchy (Implementation Phase 2)
> -----------------------------------------------------
>
> Key: ARROW-1474
> URL: https://issues.apache.org/jira/browse/ARROW-1474
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Jacques Nadeau
> Assignee: Siddharth Teotia
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
