[
https://issues.apache.org/jira/browse/ARROW-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214571#comment-16214571
]
ASF GitHub Bot commented on ARROW-1474:
---------------------------------------
icexelloss commented on issue #1203: ARROW-1474:[WIP] Java Vector Refactor
(Implementation Phase 2)
URL: https://github.com/apache/arrow/pull/1203#issuecomment-338536671
A few high level comments:
* There are a few functions that seems to be placeholder for the interface -
for instance `getNullCount` that only returns 0. I suppose these functions are
not going to be removed in 0.8? If that's the case, I think we should make it
clear to the user that these functions will not work and shouldn't be called.
Having bogus implementation could be confusing to user.
* API added in vectors classes that are for json reader/writer. I think
those shouldn't be a part of the public API. Also I am not sure why we need to
make such changes, maybe @siddharthteotia can help clarify?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [JAVA] ValueVector hierarchy (Implementation Phase 2)
> -----------------------------------------------------
>
> Key: ARROW-1474
> URL: https://issues.apache.org/jira/browse/ARROW-1474
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Jacques Nadeau
> Assignee: Siddharth Teotia
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
