[
https://issues.apache.org/jira/browse/ARROW-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215506#comment-16215506
]
ASF GitHub Bot commented on ARROW-1663:
---------------------------------------
BryanCutler commented on a change in pull request #1193: ARROW-1663: use
consistent name for null and not-null in FixedSizeLis…
URL: https://github.com/apache/arrow/pull/1193#discussion_r146339889
##########
File path: java/vector/src/main/java/org/apache/arrow/vector/ZeroVector.java
##########
@@ -109,7 +111,7 @@ public void clear() {
@Override
public Field getField() {
- return new Field(name, FieldType.nullable(new Null()), null);
+ return new Field(DATA_VECTOR_NAME, FieldType.nullable(new Null()), null);
Review comment:
That's fine, but my concern was that is `ZeroVector` only meant to ever be
an inner data vector? Or would a user ever want to make a ZeroVector and not
name it `DATA_VECTOR_NAME`? If not then I think we should just hardcode the
name "$data$" like you mentioned before. Otherwise maybe we can do something
like allow setting a name in the constructor, and create the instance with the
name "$data$".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Follow up on ARROW-1347 and make schema backward compatible
> ------------------------------------------------------------------
>
> Key: ARROW-1663
> URL: https://issues.apache.org/jira/browse/ARROW-1663
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java - Vectors
> Reporter: Yuliya Feldman
> Assignee: Yuliya Feldman
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> ARROW-1347 covered ListVector to have name of the field $data$ instead of
> [DEFAULT]
> We left FixedSizeListVector behind.
> Another case is backward compatibility - if schema was created before
> ARROW-1347 was in place application may still suffer from side effects as it
> would not be updated based on new code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
