[
https://issues.apache.org/jira/browse/ARROW-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215508#comment-16215508
]
ASF GitHub Bot commented on ARROW-1663:
---------------------------------------
BryanCutler commented on a change in pull request #1193: ARROW-1663: use
consistent name for null and not-null in FixedSizeLis…
URL: https://github.com/apache/arrow/pull/1193#discussion_r146340416
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/types/pojo/Field.java
##########
@@ -121,7 +124,18 @@ public static Field
convertField(org.apache.arrow.flatbuf.Field field) {
}
ImmutableList.Builder<Field> childrenBuilder = ImmutableList.builder();
for (int i = 0; i < field.childrenLength(); i++) {
- childrenBuilder.add(convertField(field.children(i)));
+ Field childField = convertField(field.children(i));
+ if ((field.typeType() == Type.List || field.typeType() ==
Type.FixedSizeList)
+ && childField.getName().equals(ZeroVector.NAME)) {
+ Field modifiedField = new Field(DATA_VECTOR_NAME,
childField.isNullable(), childField.getType(),
+ childField.getDictionary(),
+ childField.getChildren(),
+ childField.getTypeLayout(),
+ childField.getMetadata());
+ childrenBuilder.add(modifiedField);
+ continue;
+ }
+ childrenBuilder.add(childField);
Review comment:
Could you put this block in a separate method with a name that makes it
obvious what it is changing and why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Follow up on ARROW-1347 and make schema backward compatible
> ------------------------------------------------------------------
>
> Key: ARROW-1663
> URL: https://issues.apache.org/jira/browse/ARROW-1663
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java - Vectors
> Reporter: Yuliya Feldman
> Assignee: Yuliya Feldman
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> ARROW-1347 covered ListVector to have name of the field $data$ instead of
> [DEFAULT]
> We left FixedSizeListVector behind.
> Another case is backward compatibility - if schema was created before
> ARROW-1347 was in place application may still suffer from side effects as it
> would not be updated based on new code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
