[
https://issues.apache.org/jira/browse/ARROW-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242941#comment-16242941
]
ASF GitHub Bot commented on ARROW-972:
--------------------------------------
wesm commented on a change in pull request #1216: ARROW-972: UnionArray in
pyarrow
URL: https://github.com/apache/arrow/pull/1216#discussion_r149506402
##########
File path: cpp/src/arrow/array.cc
##########
@@ -393,6 +393,71 @@ UnionArray::UnionArray(const std::shared_ptr<DataType>&
type, int64_t length,
SetData(internal_data);
}
+std::shared_ptr<DataType> MakeUnionArrayType(
+ UnionMode mode, const std::vector<std::shared_ptr<Array>>& children) {
+ auto types = std::vector<std::shared_ptr<Field>>();
Review comment:
This might be better with the type on the LHS
(`std::vector<std::shared_ptr<Field>> types;`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Add test cases and basic APIs for UnionArray
> -----------------------------------------------------
>
> Key: ARROW-972
> URL: https://issues.apache.org/jira/browse/ARROW-972
> Project: Apache Arrow
> Issue Type: New Feature
> Components: Python
> Affects Versions: 0.3.0
> Reporter: Wes McKinney
> Assignee: Philipp Moritz
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> While this is implemented in C++, there isn't any API exposure yet in Python
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
