[
https://issues.apache.org/jira/browse/ARROW-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242945#comment-16242945
]
ASF GitHub Bot commented on ARROW-972:
--------------------------------------
wesm commented on a change in pull request #1216: ARROW-972: UnionArray in
pyarrow
URL: https://github.com/apache/arrow/pull/1216#discussion_r149510499
##########
File path: cpp/src/arrow/array.h
##########
@@ -628,6 +659,8 @@ class ARROW_EXPORT UnionArray : public Array {
/// Only use this while the UnionArray is in scope
const Array* UnsafeChild(int pos) const;
+ std::shared_ptr<DataType> value_type(int pos) const;
Review comment:
It wasn't initially clear that this is the child type, maybe call this
`child_type` instead (and add doxygen comment)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Add test cases and basic APIs for UnionArray
> -----------------------------------------------------
>
> Key: ARROW-972
> URL: https://issues.apache.org/jira/browse/ARROW-972
> Project: Apache Arrow
> Issue Type: New Feature
> Components: Python
> Affects Versions: 0.3.0
> Reporter: Wes McKinney
> Assignee: Philipp Moritz
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> While this is implemented in C++, there isn't any API exposure yet in Python
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
