[
https://issues.apache.org/jira/browse/ARROW-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252292#comment-16252292
]
ASF GitHub Bot commented on ARROW-1476:
---------------------------------------
BryanCutler commented on a change in pull request #1316: ARROW-1476: [JAVA]
Implement Final ValueVector Updates
URL: https://github.com/apache/arrow/pull/1316#discussion_r150972624
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/BaseValueVector.java
##########
@@ -122,5 +123,49 @@ public static boolean checkBufRefs(final ValueVector vv) {
public BufferAllocator getAllocator() {
return allocator;
}
+
+ protected void compareTypes(BaseValueVector target, String caller) {
+ if (this.getMinorType() != target.getMinorType()) {
+ throw new UnsupportedOperationException(caller + " should have vectors
of exact same type");
Review comment:
was this in the API before, if not maybe it would be better to just return
a boolean and the caller can throw an exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JAVA] Implement final ValueVector updates
> ------------------------------------------
>
> Key: ARROW-1476
> URL: https://issues.apache.org/jira/browse/ARROW-1476
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Jacques Nadeau
> Assignee: Siddharth Teotia
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
