[
https://issues.apache.org/jira/browse/ARROW-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252554#comment-16252554
]
ASF GitHub Bot commented on ARROW-1476:
---------------------------------------
siddharthteotia commented on issue #1316: ARROW-1476: [JAVA] Implement Final
ValueVector Updates
URL: https://github.com/apache/arrow/pull/1316#issuecomment-344420686
The Nullable scalars (fixed width and var width)
A NullableIntVector had two inner vectors -- BitVector and IntVector and we
used to delegate the operations to these inner vectors. Now instead of the
inner vectors, we just have two ArrowBufs that manage the validity and data
respectively.
The Json format doesn't need to change. However, the code that parses Json
and writes to vector or vice-versa had to be changed in JAVA because it was
written with assumption that vectors have inner vectors that can be directly
operated on. It was changed to directly work with inner buffers as opposed to
inner vectors.
Changes were needed in JsonFileReader (function readFromJsonIntoVector) and
JsonFileWriter (function writeFromVectorIntoJson) respectively.
On the C++ side, I believe similar changes are needed in json.cc (reader and
writer implementation) and json_internal.cc (ReadRecordBatch and
WriteRecordBatch) functions assuming I am looking at the correct Json handling
code in C++.
@BryanCutler, @icexelloss , since you had reviewed the Json File
reader/writer changes and later Li refactored them, do you agree with above
analysis and suggested changes on the C++ side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JAVA] Implement final ValueVector updates
> ------------------------------------------
>
> Key: ARROW-1476
> URL: https://issues.apache.org/jira/browse/ARROW-1476
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Jacques Nadeau
> Assignee: Siddharth Teotia
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
